Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboard)!: Downgrade WTForms to >=2.3.3, <3.1.0 due to compatibility issues #25643

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(dashboard)!: Downgrade WTForms to >=2.3.3, <3.1.0 due to compatibility issues #25643

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def get_git_sha() -> str:
"typing-extensions>=4, <5",
"waitress; sys_platform == 'win32'",
"werkzeug>=2.3.3, <3",
"wtforms>=2.3.3, <4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was fixed on FAB and bumped here: #25712

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed. Would it be appropriate for me to close this PR now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just posted on #25631 asking them to confirm that the issue does not persist in Superset 3.0.2, which uses a newer version of FAB. Especially if someone can confirm that this issue is solved, then I would think this PR can be closed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I closed the other issue because of a lack of response. I'm guessing it's safe now to close this issue, but let me know if anyone disagrees!

"wtforms>=2.3.3, <3.1.0",
"wtforms-json",
"xlsxwriter>=3.0.7, <3.1",
],
Expand Down
Loading