WW-5379 Use ValueStackProvider marker interface for Velocity context …

…implementation flexibility
apache · Jan 2, 2024 · 29027f3 · 29027f3
1 parent 450ee91
commit 29027f3
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 4 deletions.
diff --git a/core/src/main/java/org/apache/struts2/util/ValueStackProvider.java b/core/src/main/java/org/apache/struts2/util/ValueStackProvider.java
@@ -0,0 +1,12 @@
+package org.apache.struts2.util;
+
+import com.opensymphony.xwork2.util.ValueStack;
+
+/**
+ * @since 6.4.0
+ */
+public interface ValueStackProvider {
+
+    ValueStack getValueStack();
+
+}
diff --git a/plugins/velocity/src/main/java/org/apache/struts2/views/velocity/StrutsVelocityContext.java b/plugins/velocity/src/main/java/org/apache/struts2/views/velocity/StrutsVelocityContext.java
@@ -19,14 +19,15 @@
 package org.apache.struts2.views.velocity;
 
 import com.opensymphony.xwork2.util.ValueStack;
+import org.apache.struts2.util.ValueStackProvider;
 import org.apache.velocity.VelocityContext;
 
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
 import java.util.function.Function;
 
-public class StrutsVelocityContext extends VelocityContext {
+public class StrutsVelocityContext extends VelocityContext implements ValueStackProvider {
 
     private final ValueStack stack;
     private final List<VelocityContext> chainedContexts;
@@ -104,6 +105,7 @@ protected Object chainedContextGet(String key) {
         return null;
     }
 
+    @Override
     public ValueStack getValueStack() {
         return stack;
     }

diff --git a/...elocity/src/main/java/org/apache/struts2/views/velocity/components/AbstractDirective.java b/...elocity/src/main/java/org/apache/struts2/views/velocity/components/AbstractDirective.java
@@ -22,8 +22,8 @@
 import com.opensymphony.xwork2.util.ValueStack;
 import org.apache.struts2.ServletActionContext;
 import org.apache.struts2.components.Component;
+import org.apache.struts2.util.ValueStackProvider;
 import org.apache.struts2.views.util.ContextUtil;
-import org.apache.struts2.views.velocity.StrutsVelocityContext;
 import org.apache.velocity.context.AbstractContext;
 import org.apache.velocity.context.Context;
 import org.apache.velocity.context.InternalContextAdapter;
@@ -86,8 +86,8 @@ public boolean render(InternalContextAdapter ctx, Writer writer, Node node) thro
 
     private ValueStack extractValueStack(Context context) {
         do {
-            if (context instanceof StrutsVelocityContext) {
-                return ((StrutsVelocityContext) context).getValueStack();
+            if (context instanceof ValueStackProvider) {
+                return ((ValueStackProvider) context).getValueStack();
             }
             context = extractContext(context);
         } while (context != null);