Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-44935] Fix RELEASE file to have the correct information in Docker images if exists #68

Closed
wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Sep 18, 2024

What changes were proposed in this pull request?

This PR aims to fix RELEASE file to have the correct information in Docker images if exists.

Apache Spark repository already fixed this.

Why are the changes needed?

To provide a correct information for Spark 3.4+

Does this PR introduce any user-facing change?

No behavior change. Only RELEASE file.

How was this patch tested?

Pass the CIs.

@dongjoon-hyun
Copy link
Member Author

This is irrelevant to the functionality and K8s integration tests.
Merged to master.

@dongjoon-hyun
Copy link
Member Author

Thank you, @viirya !

@dongjoon-hyun dongjoon-hyun deleted the SPARK-44935 branch September 18, 2024 23:12
@dongjoon-hyun
Copy link
Member Author

For the record, the fixed images are released.

$ docker run -it --rm apache/spark:4.0.0-preview1 cat /opt/spark/RELEASE
Spark 4.0.0-preview1 (git revision 7a7a8bc4bab) built for Hadoop 3.4.0
Build flags: -B -Pyarn -Pkubernetes -Psparkr -Phadoop-3 -Phive -Phive-thriftserver

dongjoon-hyun added a commit to apache/spark-kubernetes-operator that referenced this pull request Sep 19, 2024
### What changes were proposed in this pull request?

This PR aims to propose to use `apache/spark` images instead of `spark` because `apache/spark` images are published first. For example, the following are only available in `apache/spark` as of now.
- apache/spark-docker#66
- apache/spark-docker#67
- apache/spark-docker#68

### Why are the changes needed?

To apply the latest bits earlier.

### Does this PR introduce _any_ user-facing change?

There is no change from `Apache Spark K8s Operator`.
Only the underlying images are changed.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #128 from dongjoon-hyun/SPARK-49706.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants