Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metrics system typo #550

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Fix metrics system typo #550

merged 1 commit into from
Oct 8, 2024

Conversation

sollhui
Copy link
Contributor

@sollhui sollhui commented Oct 8, 2024 •
edited
Loading

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#.
  • Update the CHANGES log.

@wu-sheng
Copy link
Member

wu-sheng commented Oct 8, 2024

I think you should update the dashboard setup(Grafana) accordingly?

@wu-sheng wu-sheng added this to the 0.8.0 milestone Oct 8, 2024
@wu-sheng
Copy link
Member

wu-sheng commented Oct 8, 2024

Also, changelog should be updated for 0.8.

FYI 0.7 is on the vote, this typo fix could be in 0.8-dev directly.

@wu-sheng wu-sheng added the bug Something isn't working label Oct 8, 2024
@sollhui
Copy link
Contributor Author

sollhui commented Oct 8, 2024 •
edited
Loading

I think you should update the dashboard setup(Grafana) accordingly?

This typo only involves the code level and does not require any modifications to the dashboard.

@wu-sheng
Copy link
Member

wu-sheng commented Oct 8, 2024

OK, please update the changelog.

@wu-sheng wu-sheng merged commit bcaf9a8 into apache:main Oct 8, 2024
14 checks passed
@sollhui sollhui deleted the metric_typo branch October 9, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

@hanahmily hanahmily Awaiting requested review from hanahmily

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sollhui @wu-sheng