Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue with deleting the "Host" header #5781

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

titxue
Copy link

@titxue titxue commented Nov 13, 2024

titxue and others added 3 commits November 13, 2024 10:23
@yu199195
Copy link
Member

why delete 'Host' from http header

@titxue
Copy link
Author

titxue commented Nov 13, 2024

why delete 'Host' from http header

The original logic ends up removing the ‘Host’ header, which causes any custom ‘Host’ header functionality in the request plugin to fail. My recommendation is to remove the code that deletes ‘Host’ to allow the plugin to function correctly, increasing flexibility without forcing the removal of the ‘Host’ header. Alternatively, this could be made configurable, either in the request setup or the service discovery. In any case, forcing the deletion of ‘Host’ in code is not ideal. Please also refer to the details in my submitted issue for further clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants