Enhance funnel functions to accept a new option for maxStepDuration #14434
+112
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance funnel functions to accept a new option for
maxStepDuration
.This option
maxStepDuration
will allow sliding window to not consider the step event if the interval from the previous event is too long but still within the window size.For backward compatibility, I need to model Mode and extra arguments into same category and parse those separately.
E.g. the sliding window size could be 1 day (86400000 milliseconds), however the sliding window shouldn't consider the step events if two events interval is longer than 1 hour (3600000 milliseconds).
The usage here is to add
maxStepDuration=3600000
in the extra function arguments.Example: