Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance funnel functions to accept a new option for maxStepDuration #14434

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Nov 13, 2024

Enhance funnel functions to accept a new option for maxStepDuration.

This option maxStepDuration will allow sliding window to not consider the step event if the interval from the previous event is too long but still within the window size.

For backward compatibility, I need to model Mode and extra arguments into same category and parse those separately.

E.g. the sliding window size could be 1 day (86400000 milliseconds), however the sliding window shouldn't consider the step events if two events interval is longer than 1 hour (3600000 milliseconds).

The usage here is to add maxStepDuration=3600000 in the extra function arguments.

Example:

funnelMaxStep(
    ts,
    '86400000',
    3,
    event_name = 'screen_viewed',
    event_name = 'screen_clicked',
    event_name = 'purchased',
    'strict_order',
    'maxStepDuration=3600000'
)

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 63.77%. Comparing base (59551e4) to head (801fb96).
Report is 1330 commits behind head on master.

Files with missing lines Patch % Lines
...n/funnel/window/FunnelBaseAggregationFunction.java 0.00% 23 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14434      +/-   ##
============================================
+ Coverage     61.75%   63.77%   +2.02%     
- Complexity      207     1563    +1356     
============================================
  Files          2436     2663     +227     
  Lines        133233   146164   +12931     
  Branches      20636    22400    +1764     
============================================
+ Hits          82274    93218   +10944     
- Misses        44911    46047    +1136     
- Partials       6048     6899     +851     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.76% <0.00%> (+2.05%) ⬆️
java-21 63.66% <0.00%> (+2.04%) ⬆️
skip-bytebuffers-false 63.77% <0.00%> (+2.02%) ⬆️
skip-bytebuffers-true 63.64% <0.00%> (+35.92%) ⬆️
temurin 63.77% <0.00%> (+2.02%) ⬆️
unittests 63.77% <0.00%> (+2.02%) ⬆️
unittests1 55.53% <0.00%> (+8.64%) ⬆️
unittests2 34.11% <0.00%> (+6.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangfu0 xiangfu0 changed the title Enhance funnel functions to accept a new option for stepMaxDuration Enhance funnel functions to accept a new option for maxStepDuration Nov 13, 2024
@xiangfu0 xiangfu0 force-pushed the enhance-funnel-to-discard-delayed-events branch 2 times, most recently from 0b106d0 to 1ad5a84 Compare November 13, 2024 05:08
@xiangfu0 xiangfu0 force-pushed the enhance-funnel-to-discard-delayed-events branch 2 times, most recently from 4704f22 to 2c903a7 Compare November 14, 2024 09:52
@xiangfu0 xiangfu0 force-pushed the enhance-funnel-to-discard-delayed-events branch from 2c903a7 to 801fb96 Compare November 14, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants