Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mima comparison failing #224

Merged
merged 2 commits into from
Feb 8, 2024
Merged

mima comparison failing #224

merged 2 commits into from
Feb 8, 2024

Conversation

pjfanning
Copy link
Contributor

issue is that previousStableVersion only looks at git tags and we have a v1.1.0-M0 git tag but no release of that name

Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to get unstuck now.

we have a v1.1.0-M0 git tag but no release of that name

Do we expect this to be an exceptional situation or something that happens regularly? If the former, we should add an issue to remind us to remove the workaround after the 1.1.0 release. If the latter, we should add updating this value to the release procedure.

@pjfanning
Copy link
Contributor Author

I raised sbt/sbt-dynver#283

In theory, we could submit such a fix ourselves and if it isn't merged, we can add it to one of our own sbt plugins.

@pjfanning pjfanning merged commit ffd1b49 into apache:main Feb 8, 2024
16 checks passed
@pjfanning pjfanning deleted the mima-issue branch February 8, 2024 09:08
@mdedetrich
Copy link
Contributor

Do we expect this to be an exceptional situation or something that happens regularly? If the former, we should add an issue to remind us to remove the workaround after the 1.1.0 release. If the latter, we should add updating this value to the release procedure.

This is normal, we have to create a M0 tag when we bump a major/minor so that nightly snapshots start using that new bumped major/minor version.

i.e. if we are at 1.1.x and we decide to bump the minor version we have to create a 1.2.0-M0 tag along with a branch so that nightly job will create versions starting with 1.2.0-x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants