Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mima compare version #331

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Jan 27, 2024

we are getting issues in main branch builds with mima checks - since the v1.1.0-M0 git tag was added

see https://github.com/apache/incubator-pekko-connectors/actions/runs/7678675966/job/20928810106

the issue is because the current setup uses the git tags and expects there to be releases for every git tag

We can test with "1.0.2" for the time being

I raised sbt/sbt-dynver#283 to possibly do a change there so that we could go back to using the previousStableVersion sbt variable.

Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@pjfanning pjfanning merged commit 838dcca into apache:main Jan 27, 2024
48 of 50 checks passed
@pjfanning pjfanning deleted the mima-compare-version branch January 27, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants