Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENNLP-1623: Add more test cases for Coref component #201

Merged

Conversation

mawiesne
Copy link
Contributor

@mawiesne mawiesne commented Dec 20, 2024

Change

  • adds a ton of new test classes
  • adjusts TrainModel interface to return the trained model
  • fixes several undetected class cast bugs due to '@SuppressWarnings("unchecked")' cover-up
  • makes CorefTrainerTest (somehow) pass
  • makes classes named Enum be actual enums

Code-Coverage

Bildschirmfoto 2024-12-20 um 22 45 50

Tasks

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp-sandbox folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp-sandbox folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp-sandbox folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

@mawiesne mawiesne self-assigned this Dec 20, 2024
Copy link
Contributor

@rzo1 rzo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good to me. More tests, less bugs ;-)

I have added a question regarding the source (and license?) of the huge acronym txt file.

@mawiesne mawiesne requested a review from rzo1 December 27, 2024 19:40
- adds a ton of new test classes
- adjusts TrainSimilarityModel interface to return the trained model
- fixes several undetected class cast bugs due to '@SuppressWarnings("unchecked")' cover-up
- makes CorefTrainerTest (somehow) pass
- makes classes named *Enum* be actual enums
- uses arbitrary values in example sgml, thx @rzo1
@mawiesne mawiesne force-pushed the OPENNLP-1623-Add-more-test-cases-for-Coref-component branch from 79fca99 to feb96a9 Compare December 27, 2024 19:41
@mawiesne mawiesne merged commit a380b05 into master Jan 5, 2025
4 checks passed
@mawiesne mawiesne deleted the OPENNLP-1623-Add-more-test-cases-for-Coref-component branch January 5, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants