Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENNLP-1665 - Implement TokenizerService and SentenceDetectorService #199

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

rzo1
Copy link
Contributor

@rzo1 rzo1 commented Dec 17, 2024

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp-sandbox folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp-sandbox folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp-sandbox folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

  • Implement TokenizerService and SentenceDetectorService.
  • Reduces code duplication for multiple service by using default interface methods
  • Adds Unit and Integration Tests
  • Regenerate documentation and updates README

- Reduces code duplication for multiple service by using default interface methods
- Adds Unit and Integration Tests
- Regenerate documentation and updates README
@mawiesne mawiesne changed the title OPENNLP-1665 - Implement TokenizerService and SentenceDetectorService. OPENNLP-1665 - Implement TokenizerService and SentenceDetectorService Dec 17, 2024
opennlp-grpc/README.md Outdated Show resolved Hide resolved
@rzo1
Copy link
Contributor Author

rzo1 commented Dec 19, 2024

Thanks for the reviews. I am going to integrate it, so we can proceed with additional improvements (missing default components, docker support, ...)

@rzo1 rzo1 merged commit a577a74 into master Dec 19, 2024
4 checks passed
@rzo1 rzo1 deleted the OPENNLP-1665 branch December 19, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants