Drop the cruft #225
Drop the cruft #225
Conversation
Single class mildly used it. Simple replacement added.
| @@ -185,21 +181,21 @@ | |||
| <artifactId>maven-dependency-tree</artifactId> | |||
| <version>3.2.1</version> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.apache.commons</groupId> | |||
There was a problem hiding this comment.
? really needed? this doesn't look related to the subject of the PR
There was a problem hiding this comment.
? unsure I get your comment. If you'd look carefully, you will see that I just moved this dependency from last place (as it is non test) to here. I just "moved" it to have proper dep order.
There was a problem hiding this comment.
ah right. sorry for that.
aren't we using spotless for pom?
| <dependency> | ||
| <groupId>commons-io</groupId> | ||
| <artifactId>commons-io</artifactId> | ||
| <version>2.13.0</version> | ||
| <version>2.16.1</version> |
There was a problem hiding this comment.
this doesn't look related to the subject of the PR
maybe change the subject
There was a problem hiding this comment.
changed the subject
thanks for that. The new subject is really more comprehensive :P
| @@ -79,12 +79,11 @@ | |||
| </distributionManagement> | |||
|
|
|||
| <properties> | |||
| <mavenVersion>3.6.3</mavenVersion> | |||
| <mavenVersion>3.9.7</mavenVersion> | |||
There was a problem hiding this comment.
this doesn't look related to the subject of the PR
maybe change the subject
pom.xml
Outdated
| @@ -93,12 +92,12 @@ | |||
| <dependency> | |||
| <groupId>org.eclipse.sisu</groupId> | |||
| <artifactId>org.eclipse.sisu.inject</artifactId> | |||
| <version>${sisu.version}</version> | |||
| <version>${version.sisu-maven-plugin}</version> | |||
There was a problem hiding this comment.
the property name doesn't look related to such library.
I know it's coming from the parent but this is really confusing.
There was a problem hiding this comment.
Yes, is ugly, will figure out something. My point was really to not have "disconnected" the sisu version in this plugin vs parent.
There was a problem hiding this comment.
Huh, seems it is, removing whole depMgt section and moving guice version to dep, and that's did it.
|
@cstamas, sorry, my bad. I merged it instead of only approving it, |
|
Np, this pr was "complete", so is ok to have it merged |
Drop dependencies that are superfluous (one class used) or are deprecated:
Slight updates and cleanup in dependencies.
https://issues.apache.org/jira/browse/MSHADE-473
https://issues.apache.org/jira/browse/MSHADE-474
https://issues.apache.org/jira/browse/MSHADE-475
https://issues.apache.org/jira/browse/MSHADE-476
https://issues.apache.org/jira/browse/MSHADE-477