[MDEPLOY-314] Include artifactId in DeployMojo#processProject messages #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe it is worth to look at m-install-p as it has pretty much same/similar places to update... |
8 tasks
|
merged w/ tweaks as b9c1c8b |
hboutemy
reviewed
Apr 26, 2024
| } | ||
| } else { | ||
| throw new MojoExecutionException( | ||
| "The packaging for this project did not assign a file to the build artifact"); | ||
| throw new MojoExecutionException("The packaging plugin for project " + project.getArtifactId() |
There was a problem hiding this comment.
"packaging plugin"?
there is no packaging plugin, just packaging
hboutemy
reviewed
Apr 26, 2024
| @@ -299,18 +300,19 @@ private void processProject(final MavenProject project, DeployRequest request) t | |||
| } else if (!project.getAttachedArtifacts().isEmpty()) { | |||
| if (allowIncompleteProjects) { | |||
| getLog().warn(""); | |||
| getLog().warn("The packaging plugin for this project did not assign"); | |||
| getLog().warn("The packaging plugin for project " + project.getArtifactId() + " did not assign"); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR addresses MDEPLOY-314 by including the artifact ID of the currently processed project in
MojoExecutionExceptionand warning messages.[MDEPLOY-XXX] - Fixes bug in ApproximateQuantiles, where you replaceMDEPLOY-XXXwith the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.mvn -Prun-its clean verify).To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.