PERFORMANCE: Lucene.Net.Facet.Taxonomy.WriterCache.CharBlockArray: Compare equality and calculate hash code without allocating #900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)
PERFORMANCE: Lucene.Net.Facet.Taxonomy.WriterCache.CharBlockArray: Compare equality and calculate hash code without allocating
Description
The equality and hash code generation in Lucene relied on
Subsequence()
to generate the hash code and check for equality. Subsequence always allocates. The prior implementation of equality was actually copying the characters to aStringBuilder
(which allocates), then callingStringBuilder.ToString()
(which allocates), then comparing usingString.Equals()
, which only accepts a string.This has been modified to pass
startIndex
andlength
to theCharBlockArray
when calculating hash code and comparing for binary string equality. These checks are done inCharBlockArray
itself on the original data structure rather than copying characters out to a buffer compare them.