Remove unnecessary NoInlining, #931

[paulirwin]

• You've read the Contributor Guide and Code of Conduct.
• You've included unit or integration tests for your change, where applicable.
• You've included inline docs for your change, where applicable.
• There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Remove unnecessary use of [MethodImpl(MethodImplOptions.NoInlining)]

Partial #931

Description

I need to finish reviewing the methods mentioned in calls to StackTraceHelper.DoesStackTraceContainMethod(string methodName) (the overload without the class name parameter) to make sure there aren't any false positives there, but I've at least validated that those existing usages of NoInlining seem like they might plausibly match their use in the tests.

This PR removes NoInlining from interface and abstract methods, where it has no effect because the attribute is not inherited. It also removes it from methods with empty bodies, because an empty body doesn't call anything, and thus those checks in the tests would never be true anyways. Finally, it removes it in a few other places that were not asserted in tests.

As a TODO, I left the SystemConsole attributes there, even though those are suspect. We had discussed possibly being able to remove that class anyways, but I'll defer that for now.

[NightOwl888]

Thanks. Looks good to merge.

[NightOwl888]

Oh, I didn't notice it is still a draft. Feel free to re-request a review when the PR is ready.

[paulirwin]

I'll go ahead and split out the remaining investigation work into its own PR, and merge this one as it's a nice seam.