SWEEP: Replace IndexOutOfRangeException with ArgumentOutOfRangeException except for indexer use, #1023 #1083
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces IndexOutOfRangeException use with ArgumentOutOfRangeException when thrown from a method rather than an indexer.
Fixes #1023
Description
It is not correct in .NET to use IndexOutOfRangeException to throw exceptions from a non-indexer method when an argument is out of range, even if that argument is named
index
; that is what ArgumentOutOfRangeException is for. Additionally, this has the added benefit of having theparamName
set to know which argument is out of range.