BREAKING: Static field cleanup, #662, #679 #1079
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts static readonly fields to const, where possible. Also addresses csharpsquid:S2223 issues with mutable static fields.
Fixes #662
Fixes #679
Description
This PR converts most static readonly fields to const where it is possible to do so. Some notable exceptions:
This also addresses #679 with non-readonly static fields, where one of three things happened: