Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support list server configs by admin cli tool #6702

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Sep 18, 2024

🔍 Description

Issue References 🔗

This pull request fixes #

Describe Your Solution 🔧

  • add command list config in admin cli tool , for listing all the server configs, which is useful for checking runtime configs when before/after refreshing the configs of user-defaults or non-user-defaults

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

@bowenliang123 bowenliang123 changed the title [WIP] support list server configs in admin tool [WIP] support list server configs by admin cli tool Sep 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 45 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (8056235) to head (1c1d58d).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...g/apache/kyuubi/client/api/v1/dto/ConfigEntry.java 0.00% 17 Missing ⚠️
...e/kyuubi/ctl/cmd/list/AdminListConfigCommand.scala 0.00% 7 Missing ⚠️
...rg/apache/kyuubi/server/api/v1/AdminResource.scala 0.00% 6 Missing ⚠️
...in/java/org/apache/kyuubi/client/AdminRestApi.java 0.00% 5 Missing ⚠️
...main/scala/org/apache/kyuubi/ctl/util/Render.scala 0.00% 4 Missing ⚠️
...in/scala/org/apache/kyuubi/config/KyuubiConf.scala 0.00% 3 Missing ⚠️
...a/org/apache/kyuubi/ctl/opt/AdminCommandLine.scala 0.00% 2 Missing ⚠️
...ache/kyuubi/ctl/cli/AdminControlCliArguments.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6702   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         684     686    +2     
  Lines       42279   42324   +45     
  Branches     5765    5770    +5     
======================================
- Misses      42279   42324   +45     
Flag Coverage Δ
0.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bowenliang123 bowenliang123 changed the title [WIP] support list server configs by admin cli tool support list server configs by admin cli tool Sep 20, 2024
@pan3793
Copy link
Member

pan3793 commented Sep 22, 2024

listing configurations should be restricted to admin only. additionally, we may need to have another parameter to define the display mode for configuration values, e.g.

  • ALL - display all configuration values as-is
  • REDACTED - to avoid displaying password/secret values

PS: I remember there was a similar request to have a configuration display mode of configurations for retrieving batch info

@bowenliang123 bowenliang123 marked this pull request as ready for review September 25, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants