Fix Non-Deterministic Test - testChunkCache #14099
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test ChunkCacheTest#testChunkCache fails under NonDex tool which detects non-deterministic nature of tests.
How to Reproduce
Error
java.lang.AssertionError:
expected: org.apache.tsfile.file.header.ChunkHeader<CHUNK_HEADER{measurementID='null', dataSize=189, dataType=DOUBLE, compressionType=UNCOMPRESSED, encodingType=PLAIN, numOfPages=0, serializedSize=14}>
but was: org.apache.tsfile.file.header.ChunkHeader<CHUNK_HEADER{measurementID='null', dataSize=189, dataType=DOUBLE, compressionType=UNCOMPRESSED, encodingType=PLAIN, numOfPages=0, serializedSize=14}>
Proposed Solution
Instead of asserting the objects directly, assert the objects' content as the objects might be different, but their content would be the same.
Please let me know if you have any questions or need any additional justification/changes from my side.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR