Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-1069][Doc] Add Connector Binary file v1.18 to download page #1071

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

PeterZh6
Copy link
Contributor

Fixes #1069

Motivation

Connector Binary file v1.18 is not listed in download page. However, they have been released on the maven repository of apache inlong. It should be added to reflect this change, while also resolving confusions as some examples in the website require users to use connector-v1.18

Modifications

Added one more row for Connector Binary file v1.18

Verifying this change

image

  • Make sure that the change passes the CI checks.

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:

  • This change added tests and can be verified as follows:

@dockerzhang
Copy link
Contributor

@PeterZh6 1.13 is not recommended now, you can remove it, only keep 1.15 and 1.18.

Copy link
Contributor

@aloyszhang aloyszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@aloyszhang aloyszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there so many changes in package-lock.json

@PeterZh6
Copy link
Contributor Author

Why are there so many changes in package-lock.json

Sorry for this. Problem fixed.

@PeterZh6 PeterZh6 requested a review from aloyszhang October 29, 2024 04:52
@dockerzhang dockerzhang merged commit 9c111ff into apache:master Oct 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Doc] Connector Binary file v1.18 not listed in download page
3 participants