Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-1055][Doc] Add documentation for developing user-defined flink metrics #1056

Merged
merged 6 commits into from
Oct 16, 2024

Conversation

PeterZh6
Copy link
Contributor

Fixes #1055

Motivation

This PR addresses the lack of documentation for user-defined Flink metrics in the inlong-sort component. Recent updates introduced new metrics capabilities, but there is limited guidance on how to add and integrate custom metrics, especially when creating a new connector. This documentation aims to provide clear development instructions to help developers more easily customize and extend metrics within inlong-sort.

Modifications

  • Added a detailed guide on defining, registering, and utilizing custom Flink metrics in the inlong-sort framework.
  • Included examples and code snippets for creating and integrating metrics with connectors, focusing on deserialization error tracking.
  • Provided instructions on testing and verifying new metrics using sort-end-to-end-tests.
  • Outlined potential issues and best practices, such as handling null pointers and ensuring correct metric registration.

Verifying this change

  • Ensure that the documentation additions are aligned with the latest metrics capabilities and that they pass CI checks.

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:

    • Documentation-only change, with no direct impact on code functionality.
  • This change added tests and can be verified as follows:

    • N/A (Documentation-only PR)

Demo Screenshots of this change:
Chinese Version:
DocDemoChinese

English Version:
DocDemoENg

Documentation

  • Does this pull request introduce a new feature? No
  • If yes, how is the feature documented? N/A
  • If a feature is not applicable for documentation, explain why? Documentation is the primary focus of this PR.
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation: N/A

Copy link
Contributor

@aloyszhang aloyszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion, the doc file name change from sort_self_defined_metrics to custom_flink_metrics

@PeterZh6 PeterZh6 changed the title [INLONG-1055][Doc] Add Documentation for Developing User-Defined Flink Metrics [INLONG-1055][Doc] Add documentation for developing user-defined flink metrics Oct 14, 2024
@aloyszhang aloyszhang merged commit b60ae76 into apache:master Oct 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Doc] Add Documentation for Developing User-Defined Flink Metrics
3 participants