Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2343] Improvement: Fix the warning Discovered module-info.class. Shading will break its strong encapsulation. #2345

Merged
merged 1 commit into from
Jan 17, 2025
Merged

[#2343] Improvement: Fix the warning Discovered module-info.class. Shading will break its strong encapsulation. #2345

merged 1 commit into from
Jan 17, 2025
+6 −0

Conversation

cchung100m
Copy link
Collaborator

What changes were proposed in this pull request?

Fix the warning Discovered module-info.class. Shading will break its strong encapsulation.

Why are the changes needed?

Fix: #2343

Does this PR introduce any user-facing change?

No.

How was this patch tested?

current UT

@cchung100m cchung100m self-assigned this Jan 16, 2025
@cchung100m
[apache#2343] Improvement: Fix the warning Discovered module-info.cla…
32c0c9e 
…ss. Shading will break its strong encapsulation.
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading

Test Results

 2 966 files  ±0   2 966 suites  ±0   6h 28m 6s ⏱️ + 1m 37s
 1 100 tests ±0   1 098 ✅ ±0   2 💤 ±0  0 ❌ ±0 
13 774 runs  ±0  13 744 ✅ ±0  30 💤 ±0  0 ❌ ±0 

Results for commit 32c0c9e. ± Comparison against base commit 4288efe.

♻️ This comment has been updated with latest results.

@cchung100m cchung100m marked this pull request as ready for review January 16, 2025 14:07
jerqi
jerqi approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution.

@cchung100m
Copy link
Collaborator Author

Thanks to @jerqi for the review. 😄

@jerqi jerqi merged commit 3bce707 into apache:master Jan 17, 2025
43 checks passed
@cchung100m cchung100m deleted the issue-2343 branch January 17, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerqi jerqi jerqi approved these changes

Assignees

@cchung100m cchung100m

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement] Fix the warning: Discovered module-info.class. Shading will break its strong encapsulation.
2 participants
@cchung100m @jerqi