[MINOR] fix(spark-client): Fix fallback to sort fail issue #2329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2329 +/- ##
============================================
+ Coverage 51.19% 52.01% +0.81%
- Complexity 2936 2938 +2
============================================
Files 486 465 -21
Lines 24720 22181 -2539
Branches 2041 2041
============================================
- Hits 12656 11537 -1119
+ Misses 11274 9928 -1346
+ Partials 790 716 -74 ☔ View full report in Codecov by Sentry. |
jerqi
reviewed
Jan 6, 2025
| @@ -104,6 +104,7 @@ private ShuffleManager createShuffleManagerInDriver() throws RssException { | |||
| Constants.SORT_SHUFFLE_MANAGER_NAME, sparkConf, true); | |||
| sparkConf.set(RssSparkConfig.RSS_ENABLED.key(), "false"); | |||
| sparkConf.set("spark.shuffle.manager", "sort"); | |||
| sparkConf.set("spark.shuffle.service.enabled", "true"); | |||
There was a problem hiding this comment.
If the user doesn't enable external shuffle, this config option shouldn't be true.
There was a problem hiding this comment.
But if it is false, sort shuffle manager cannot work
There was a problem hiding this comment.
Sort shuffle manager can work without external shuffle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix fallback to sort fail issue
Why are the changes needed?
Support fallback to sort shuffle service.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UTs.