Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] fix(test): Disable System exit for HadoopTestBase #2327

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

maobaolong
Copy link
Member

What changes were proposed in this pull request?

Disable System exit for HadoopTestBase

Why are the changes needed?

Without this, we cannot find the root cause of failure test, we can only find out the test process crashed.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing UTs.

Copy link

github-actions bot commented Jan 5, 2025

Test Results

 2 966 files  ±0   2 966 suites  ±0   6h 27m 4s ⏱️ -14s
 1 100 tests ±0   1 098 ✅ ±0   2 💤 ±0  0 ❌ ±0 
13 774 runs  ±0  13 744 ✅ ±0  30 💤 ±0  0 ❌ ±0 

Results for commit a3bc7d0. ± Comparison against base commit 3b0521a.

♻️ This comment has been updated with latest results.

@maobaolong maobaolong closed this Jan 5, 2025
@maobaolong maobaolong reopened this Jan 5, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.62%. Comparing base (580b4f2) to head (a3bc7d0).
Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2327      +/-   ##
============================================
+ Coverage     51.19%   51.62%   +0.43%     
- Complexity     2936     2966      +30     
============================================
  Files           486      477       -9     
  Lines         24720    22668    -2052     
  Branches       2041     2086      +45     
============================================
- Hits          12656    11703     -953     
+ Misses        11274    10227    -1047     
+ Partials        790      738      -52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maobaolong maobaolong merged commit 74366d5 into apache:master Jan 6, 2025
83 of 85 checks passed
@maobaolong
Copy link
Member Author

@jerqi Thanks for your review. Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants