[#2269] refactor: Fix duplicated blockIds issue caused by duplicated reportShuffleResult #2270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2270 +/- ##
============================================
- Coverage 51.78% 51.76% -0.03%
+ Complexity 2966 2965 -1
============================================
Files 479 479
Lines 22566 22569 +3
Branches 2068 2069 +1
============================================
- Hits 11686 11683 -3
- Misses 10140 10149 +9
+ Partials 740 737 -3 ☔ View full report in Codecov by Sentry. |
jerqi
reviewed
Dec 3, 2024
| @@ -797,6 +798,11 @@ private ReportShuffleResultResponse doReportShuffleResult(ReportShuffleResultReq | |||
| try { | |||
| ReportShuffleResultResponse response = getBlockingStub().reportShuffleResult(rpcRequest); | |||
| return response; | |||
| } catch (StatusRuntimeException e) { | |||
jerqi
changed the title
|
@jerqi Thank you very much to inspire me to improve the code to be better. PTAL. |
|
@jerqi Sorry, there is a spotbug issue and I just fixed it. PTAL |
jerqi
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Client stop retrying and throw RssException for reportShuffleResult operation while interrupted by caller.
Why are the changes needed?
Fix: #2269
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No need