Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1782] fix: Fix flaky test ShuffleBufferManagerTest #2100

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

maobaolong
Copy link
Member

@maobaolong maobaolong commented Sep 7, 2024

What changes were proposed in this pull request?

As title.

Why are the changes needed?

Fix: #1782

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing UTs.

@maobaolong
Copy link
Member Author

@rickyma Would you like to take a look at this PR? Thanks!

@maobaolong maobaolong closed this Sep 7, 2024
@maobaolong maobaolong reopened this Sep 7, 2024
Copy link

github-actions bot commented Sep 7, 2024

Test Results

 2 966 files  ±0   2 966 suites  ±0   6h 27m 18s ⏱️ +11s
 1 097 tests ±0   1 095 ✅ ±0   2 💤 ±0  0 ❌ ±0 
13 750 runs  ±0  13 720 ✅ ±0  30 💤 ±0  0 ❌ ±0 

Results for commit 0cfc4d8. ± Comparison against base commit d7aad66.

♻️ This comment has been updated with latest results.

@maobaolong maobaolong closed this Sep 7, 2024
@maobaolong maobaolong reopened this Sep 7, 2024
@maobaolong maobaolong closed this Sep 7, 2024
@maobaolong maobaolong reopened this Sep 7, 2024
@maobaolong maobaolong closed this Sep 8, 2024
@maobaolong maobaolong reopened this Sep 8, 2024
Copy link
Contributor

@rickyma rickyma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a temporary solution. I'm fine with it.
If there are better solutions in the future, please refactor this ASAP.

@maobaolong maobaolong closed this Jan 3, 2025
@maobaolong maobaolong reopened this Jan 3, 2025
@maobaolong
Copy link
Member Author

@rickyma Thanks for your review. Merged

@maobaolong maobaolong merged commit 8aa3616 into apache:master Jan 4, 2025
213 of 253 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] ConcurrentModificationException is thrown when calling Roaring64NavigableMap.getLongCardinality
2 participants