Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixed] fixed envsetting unload flink-conf.yaml,if not like catalogstore conf will not work #4108

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Mrart
Copy link
Contributor

@Mrart Mrart commented Oct 5, 2024

What changes were proposed in this pull request

Issue Number: close #4107

Brief change log

fixed envsetting unload flink-conf.yaml,if not like catalogstore conf will not work

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): ( no)

@github-actions github-actions bot added the FLINK label Oct 5, 2024
Copy link

sonarcloud bot commented Oct 5, 2024

Copy link
Member

@ChengJie1053 ChengJie1053 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

case null | "" =>
throw new ExceptionInInitializerError(
"[StreamPark] Usage:can't find config,please set \"--flink.conf $conf \" in main arguments")
case conf => builder.withConfiguration(Configuration.fromMap(PropertiesUtils.fromYamlText(DeflaterUtils.unzipString(conf))))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, but the method builder.withConfiguration has compatibility issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] env settings unload from flink-conf.yaml
3 participants