Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Improvements related to Spark & Flink class-names #4097

Merged
merged 7 commits into from
Sep 27, 2024

Conversation

wolfboys
Copy link
Member

@wolfboys wolfboys commented Sep 27, 2024

[Improve] Improvements related to Spark and Flink class names

What changes were proposed in this pull request

  1. FlinkDevelopmentMode rename to FlinkJobType
  2. FlinkExecutionMode rename to FlinkDeployMode
  3. SparkExecutionMode rename to SparkJobType
  4. SparkExecutionMode rename to SparkDeployMode

Brief change log

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): (yes / no)

Copy link

sonarcloud bot commented Sep 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@wolfboys wolfboys changed the title [Improve] spark-app submit bug fixed. [Improve] [Improve] Improvements related to Spark & Flink class-names Sep 27, 2024
@wolfboys wolfboys changed the title [Improve] [Improve] Improvements related to Spark & Flink class-names [Improve] Improvements related to Spark & Flink class-names Sep 27, 2024
Copy link
Member

@wangsizhu0504 wangsizhu0504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfboys wolfboys merged commit 92bf923 into apache:dev Sep 27, 2024
47 of 49 checks passed
@wolfboys wolfboys deleted the spark-submit branch September 27, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants