Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

refactor!: refactor shard version logic #264

Merged
merged 12 commits into from
Nov 8, 2023

Conversation

ZuLiangWang
Copy link
Contributor

@ZuLiangWang ZuLiangWang commented Oct 27, 2023

Rationale

Refer to this issue: #263

Detailed Changes

  • Reconstruct the process of create/drop table so that the update of shard version depends on CeresDB

Test Plan

Pass existing unit tests and integration tests.

ShiKaiWi
ShiKaiWi previously approved these changes Oct 31, 2023
server/coordinator/eventdispatch/dispatch.go Outdated Show resolved Hide resolved
server/cluster/metadata/types.go Outdated Show resolved Hide resolved
@ShiKaiWi ShiKaiWi self-requested a review October 31, 2023 06:24
@ShiKaiWi ShiKaiWi dismissed their stale review October 31, 2023 06:25

It's a mistake.

@ZuLiangWang ZuLiangWang force-pushed the refactor_shard_version branch 2 times, most recently from b4541ef to edcdfdf Compare November 6, 2023 06:19
@ZuLiangWang ZuLiangWang marked this pull request as ready for review November 6, 2023 06:19
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #264 (19c997b) into main (7f1354e) will increase coverage by 19.23%.
Report is 66 commits behind head on main.
The diff coverage is 55.95%.

❗ Current head 19c997b differs from pull request most recent head 0837539. Consider uploading reports for the commit 0837539 to get more accurate results

@@             Coverage Diff             @@
##             main     #264       +/-   ##
===========================================
+ Coverage   39.66%   58.89%   +19.23%     
===========================================
  Files          34       42        +8     
  Lines        4213     5807     +1594     
===========================================
+ Hits         1671     3420     +1749     
+ Misses       2317     1972      -345     
- Partials      225      415      +190     
Files Coverage Δ
pkg/coderr/code.go 0.00% <ø> (ø)
pkg/coderr/error.go 39.02% <100.00%> (+1.52%) ⬆️
server/coordinator/lock/entry_lock.go 100.00% <100.00%> (ø)
server/coordinator/procedure/delay_queue.go 91.30% <100.00%> (+0.25%) ⬆️
server/coordinator/procedure/util.go 0.00% <ø> (ø)
server/etcdutil/config.go 100.00% <ø> (ø)
server/etcdutil/util.go 45.45% <ø> (ø)
server/id/reusable_id_impl.go 100.00% <100.00%> (ø)
server/member/lease.go 78.62% <100.00%> (+1.46%) ⬆️
server/storage/key_path.go 100.00% <ø> (ø)
... and 32 more

server/cluster/manager.go Outdated Show resolved Hide resolved
server/cluster/manager.go Outdated Show resolved Hide resolved
server/cluster/manager.go Outdated Show resolved Hide resolved
server/cluster/metadata/cluster_metadata.go Outdated Show resolved Hide resolved
server/cluster/metadata/cluster_metadata.go Outdated Show resolved Hide resolved
server/coordinator/procedure/ddl/common_util.go Outdated Show resolved Hide resolved
server/coordinator/procedure/test/common.go Outdated Show resolved Hide resolved
server/cluster/manager.go Outdated Show resolved Hide resolved
server/cluster/metadata/topology_manager.go Outdated Show resolved Hide resolved
server/cluster/metadata/topology_manager.go Show resolved Hide resolved
server/coordinator/procedure/ddl/common_util.go Outdated Show resolved Hide resolved
@ZuLiangWang ZuLiangWang force-pushed the refactor_shard_version branch 3 times, most recently from cf90aef to 2defd97 Compare November 8, 2023 07:33
@ShiKaiWi ShiKaiWi changed the title refactor: refactor shard version logic refactor!: refactor shard version logic Nov 8, 2023
@ShiKaiWi ShiKaiWi merged commit 7afb295 into apache:main Nov 8, 2023
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants