This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
refactor!: refactor shard version logic #264
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiKaiWi
previously approved these changes
Oct 31, 2023
ZuLiangWang
force-pushed
the
refactor_shard_version
branch
2 times, most recently
from
November 6, 2023 06:19
b4541ef
to
edcdfdf
Compare
ZuLiangWang
force-pushed
the
refactor_shard_version
branch
from
November 6, 2023 06:20
edcdfdf
to
fadb57f
Compare
ZuLiangWang
force-pushed
the
refactor_shard_version
branch
from
November 6, 2023 09:41
5c7b76c
to
cb114ca
Compare
ZuLiangWang
force-pushed
the
refactor_shard_version
branch
from
November 6, 2023 11:30
961c75d
to
daad79b
Compare
Codecov Report
@@ Coverage Diff @@
## main #264 +/- ##
===========================================
+ Coverage 39.66% 58.89% +19.23%
===========================================
Files 34 42 +8
Lines 4213 5807 +1594
===========================================
+ Hits 1671 3420 +1749
+ Misses 2317 1972 -345
- Partials 225 415 +190
|
ShiKaiWi
reviewed
Nov 7, 2023
server/coordinator/procedure/ddl/droppartitiontable/create_drop_partition_table_test.go
Outdated
Show resolved
Hide resolved
server/coordinator/procedure/ddl/droppartitiontable/drop_partition_table.go
Outdated
Show resolved
Hide resolved
ZuLiangWang
force-pushed
the
refactor_shard_version
branch
from
November 7, 2023 06:45
19c997b
to
6ade423
Compare
16 tasks
ShiKaiWi
reviewed
Nov 8, 2023
ZuLiangWang
force-pushed
the
refactor_shard_version
branch
3 times, most recently
from
November 8, 2023 07:33
cf90aef
to
2defd97
Compare
ZuLiangWang
force-pushed
the
refactor_shard_version
branch
from
November 8, 2023 07:40
2defd97
to
6d72800
Compare
ShiKaiWi
changed the title
refactor: refactor shard version logic
refactor!: refactor shard version logic
Nov 8, 2023
ShiKaiWi
approved these changes
Nov 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Refer to this issue: #263
Detailed Changes
Test Plan
Pass existing unit tests and integration tests.