Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] [GLUTEN-8410][VL] Support null type in HashAggregate #8411

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[DNM] [GLUTEN-8410][VL] Support null type in HashAggregate #8411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions backends-velox/src/test/scala/org/apache/gluten/execution/MiscOperatorSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1985,4 +1985,10 @@ class MiscOperatorSuite extends VeloxWholeStageTransformerSuite with AdaptiveSpa
}
}
}

test("support null type in aggregate") {
runQueryAndCompare("SELECT max(null), min(null) from range(10)".stripMargin) {
checkGlutenOperatorMatch[HashAggregateExecTransformer]
}
}
}
4 changes: 4 additions & 0 deletions cpp/velox/substrait/VeloxSubstraitSignature.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,10 @@ TypePtr VeloxSubstraitSignature::fromSubstraitSignature(const std::string& signa
return DATE();
}

if (signature == "nothing") {
return UNKNOWN();
}

auto startWith = [](const std::string& str, const std::string& prefix) {
return str.size() >= prefix.size() && str.substr(0, prefix.size()) == prefix;
};
Expand Down
Loading