Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split metadata tables into separate modules #872

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rshkv
Copy link

@rshkv rshkv commented Jan 3, 2025

Split metadata tables into separate modules.

Context for this is to address #863 (comment) where the point was made that metadata_scan.rs will grow unwieldy if we shove all metadata table implementations in there. Especially as we're going to add extra utilities for those metadata tables.

The structure in this PR is:

inspect/
  metadata_table.rs: contains TableMetadata
  snapshots.rs: contains "snapshots" table
  manifests.rs: contains "manifests" table

In the future this can expand as described in #863 (comment).

@rshkv
Copy link
Author

rshkv commented Jan 5, 2025

cc @liurenjie1024 @Xuanwo

@rshkv rshkv force-pushed the wr/metadata-split branch from e8cabed to be77803 Compare January 5, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant