Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/update sort order #1465

Closed
wants to merge 4 commits into from
Closed

Conversation

JasperHG90
Copy link

No description provided.

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JasperHG90 for picking this up. This looks like a great first step, but it currently acts as a no-op. I think we need to add three things:

For the tests, we can come up with something similar to the partition spec evolution: https://github.com/apache/iceberg-python/blob/main/tests/integration/test_partition_evolution.py

Let me know if you run into anything, happy to help!

@JasperHG90
Copy link
Author

Thanks @Fokko ! Hadn't realized that I opened the PR against this repo already. This is just scaffolding code. I will update it the coming week with the actual logic.

@JasperHG90 JasperHG90 closed this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants