"how to release", add gh command to trigger workflow
#1387
Conversation
|
@kevinjqliu Nice work! What do you think about having a Makefile with these commands? I think it would be easier than copying and pasting from the documentation. |
|
@ndrluis thats a good point! something like |
|
going to reuse this PR based on the new release instructions from #1391 |
There was a problem hiding this comment.
Left some nits. I think it would be good to migrate to gh to reduce the risk of human error. I agree with @ndrluis that it would be good to have a more integral script at some point, but I'm also okay doing it in an incremental fashion.
| Or if `gh` is available, trigger the action using: | ||
|
|
||
| ```bash | ||
| gh workflow run python-release.yml --repo apache/iceberg-python --ref ${GIT_TAG} --field version=main |
There was a problem hiding this comment.
How about instead of having to trigger this manually, we could also trigger this by the tag creation. That's one of the first steps of the RC process: https://py.iceberg.apache.org/how-to-release/#create-tag This would trigger a job without having to do anything manual, similar to Iceberg-Go: https://github.com/apache/iceberg-go/blob/c1ffe04d56e31e475b52ce75fcbf16818a6e1169/.github/workflows/rc.yml#L24-L25
|
|
||
| ```bash | ||
| gh workflow run python-release.yml --repo apache/iceberg-python --ref ${GIT_TAG} --field version=main | ||
| SVN_RUN_ID=$(gh run list --repo apache/iceberg-python --json databaseId -q '.[0].databaseId') |
There was a problem hiding this comment.
I think this takes the latest run, would that be safe? Or should we do some more filtering
|
closing this in favor of #1391 where the workflow is triggered by tag push |
Add gh commands instead of trigger manually on github