[infra] Prevent running python-release action without a specified rc version
#1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
changed the title
python-release action without specifying rc versionpython-release action without a specified rc version
kevinjqliu
commented
Nov 28, 2024
| echo "Version input is: ${{ github.event.inputs.version }}" | ||
|
|
||
| - name: Validate version input | ||
| if: ${{ github.event.inputs.version != 'main' && !contains(github.event.inputs.version, 'rc') }} |
There was a problem hiding this comment.
had to do this since we run on different os environments with different default shells
|
closing in favor of #1391 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running without RC version, artifacts will be published to PyPi as the "official version", which is not what we want.
Let's always run with RC version (or as
main) to prevent accidentally pushing new official versions to PyPi.When the RC passes, releasing as the official version downloads artifacts from SVN
https://github.com/apache/iceberg-python/blob/main/mkdocs/docs/how-to-release.md#upload-the-accepted-release-to-pypi
Testing
0.8.1failed https://github.com/kevinjqliu/iceberg-python/actions/runs/12060385596/job/33630708983mainsucceeded https://github.com/kevinjqliu/iceberg-python/actions/runs/12060379890/job/336306922130.8.1rc1succeeded https://github.com/kevinjqliu/iceberg-python/actions/runs/12060386335/job/33630711338