Skip to content

Commit

Permalink
HBASE-28883 Manage hbase-thirdparty transitive dependencies via BOM pom
Browse files Browse the repository at this point in the history
  • Loading branch information
NihalJain committed Sep 25, 2024
1 parent a98a74b commit 0f3dae4
Show file tree
Hide file tree
Showing 2 changed files with 115 additions and 0 deletions.
105 changes: 105 additions & 0 deletions hbase-thirdparty-bom/pom.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,105 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<!--
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
ON MVN COMPILE NOT WORKING
If you wondering why 'mvn compile' does not work building HBase
(in particular, if you are doing it for the first time), instead do
'mvn package'. If you are interested in the full story, see
https://issues.apache.org/jira/browse/HBASE-6795.
-->
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.apache.hbase.thirdparty</groupId>
<artifactId>hbase-thirdparty</artifactId>
<version>${revision}</version>
<relativePath>..</relativePath>
</parent>
<artifactId>hbase-thirdparty-bom</artifactId>
<name>Apache HBase Thirdparty - BOM</name>
<description>
Bill of Materials for dependencies common to HBase Thirdparty and HBase main code
</description>
<packaging>pom</packaging>
<dependencyManagement>
<dependencies>
<dependency>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
<version>${internal.protobuf.version}</version>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-bom</artifactId>
<version>${netty4.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
<groupId>com.google.errorprone</groupId>
<artifactId>error_prone_annotations</artifactId>
<version>${error_prone_annotations.version}</version>
</dependency>
<dependency>
<groupId>javax.servlet</groupId>
<artifactId>javax.servlet-api</artifactId>
<version>${servlet-api.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
<version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>${jackson.databind.version}</version>
</dependency>
</dependencies>
</dependencyManagement>
<build>
<plugins>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>flatten-maven-plugin</artifactId>
<configuration>
<flattenMode>bom</flattenMode>
</configuration>
<executions>
<execution>
<goals>
<goal>flatten</goal>
</goals>
<phase>process-resources</phase>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project>
10 changes: 10 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
</license>
</licenses>
<modules>
<module>hbase-thirdparty-bom</module>
<module>hbase-shaded-protobuf</module>
<module>hbase-shaded-netty</module>
<module>hbase-shaded-netty-tcnative</module>
Expand Down Expand Up @@ -151,6 +152,15 @@
<jakarta.validation-api.version>2.0.2</jakarta.validation-api.version>
<javassist.version>3.30.2-GA</javassist.version>
<jackson-jaxrs-json-provider.version>2.17.2</jackson-jaxrs-json-provider.version>
<!-- TODO Had added this to see if proprties are passed on via BOM.
Will not work unless we make this as parent to hbase, should drop this before commit.
Keeping here just for demonstration purpose.
-->
<internal.protobuf.version>${protobuf.version}</internal.protobuf.version>
<netty4.version>${netty.version}</netty4.version>
<error-prone.version>${error_prone_annotations.version}</error-prone.version>
<jackson.version>${jackson-jaxrs-json-provider.version}</jackson.version>
<jackson.databind.version>${jackson-jaxrs-json-provider.version}</jackson.databind.version>
</properties>
<build>
<pluginManagement>
Expand Down

0 comments on commit 0f3dae4

Please sign in to comment.