-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-28382 Support building hbase-connectors with JDK17 #132
base: master
Are you sure you want to change the base?
Conversation
NihalJain
commented
Aug 17, 2024
•
edited
Loading
edited
- Remove EOL'ed gmaven-plugin which is unnecessarily too complex and does not work with JDK17
- Refactor flags for UT and IT for ease of profile based run
- Bump and replace mockito-all with mockito-bom and update dependencies as needed
- Copy JDK17 flags from HBase and Spark
- Add profile for JDK11 and JDK17 build
Marking as draft, will self review first and make it non-draft later! |
- Remove EOL'ed gmaven-plugin which is unnecessarily too complex and does not work with JDK17 - Refactor flags for UT and IT for ease of profile based run - Bump and replace mockito-all with mockito-bom and update dependencies as needed - Copy JDK17 flags from HBase and Spark - Add profile for JDK11 and JDK17 build
🎊 +1 overall
This message was automatically generated. |
Hi @Reidddddd would you be able to review this one? |
Can you also update the Jenkinsfile with additional stages so that we test builds on all the supported JVM major versions? |
That is, I assume that this commit does not also deprecate the JDK11 (and JDK8?) support. |
Hi @ndimiduk thank you for having a look at this one.
Sure I had created a sub task to handle the build part: HBASE-28789. But I could update the current PR as well to take care of same. Let me know how I should proceed.
Yes it does not deprecate JDK8 support. |
Ah okay. Sorry, I only looked at the PR, not Jira. Yes, I think it would be nice if it all happened together because then the new pre-commit checker will verify the code before it lands in the repo. Only if one or the other change ends up being too big for reviews to be practical would I separate them. |
Sure let me work and update this PR with Jenkins related changes as well. |
</properties> | ||
</profile> | ||
<profile> | ||
<id>build-with-jdk11</id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be better to have exclusive profiles ?
We could see all settings in one place then.