-
Notifications
You must be signed in to change notification settings - Fork 327
HAWQ-1660. Optimize parquet scan when bloom filter enabled. #1397
base: master
Are you sure you want to change the base?
Conversation
It is a good optimization point. If a lot of columns will be projected, we can only fetch joinkey and do a bloomfilter check, if doesn't match, no need to fetch other columns. But in this PR, if bloomfilter is not enable, it will fetch joinkey in the first loop, and fetch other columns in the second loop, which needs a little refine further. |
src/backend/cdb/cdbparquetrowgroup.c
Outdated
} | ||
|
||
/* skip those attributes not in given list */ | ||
if (attsList != NIL && list_find_int(attsList, i) >= 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo, should be < 0
@kuien I do a perf test on your pr, two issues:
Details see below, please check code, thanks. TPCH1G data on my mac, master code
your code
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix issues.
@kuien |
No description provided.