-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#5289][Improvement] CatalogMysqlDriverIT miss driver url #5431
base: main
Are you sure you want to change the base?
Conversation
@mchades Hello, I submitted a PR here and it has been successfully built. I see that there are still two integration tests that have not been successful. Do you need me to fix them as well |
sure, you should resolve these issues to ensure the CI passes. |
@lsyulong https://github.com/apache/gravitino/actions/runs/11675764065/job/32524822188?pr=5431 this failure seems not a flaky CI problem, maybe due to your changes, can you please fix the tests? |
Okay, I'll take a look |
|
@jerryshao @mchades Two teachers, I submitted the code and found that the integration test failed to build again. Can you provide me with some help |
@lsyulong |
ok, thanks |
|
Let me clarify the original problem. The version of the JDBC driver is If we set the version of the JDBC driver to |
@yuqi1129 OK, my understanding is to add back the missing content from the CatalogDoris Driver IT and CatalogMysql Driver IT classes. The rest of the code structure and logic have changed. Do we still need to add this part? |
I don't think so. The only thing you need to do is to set driver version to |
@lsyulong |
ok |
What changes were proposed in this pull request?
[#5289][Improvement] CatalogMysqlDriverIT miss driver url
Why are the changes needed?
[#5289][Improvement] CatalogMysqlDriverIT miss driver url
Fix: #5289
Does this PR introduce any user-facing change?
no
How was this patch tested?
no