[#5410] Improvement(iceberg-reset): Make IT IcebergRestKerberosHiveCatalogIT works in deploy mode.
#5423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please help to review this PR, thanks. |
FANNG1
reviewed
Nov 1, 2024
| tempDir + HIVE_METASTORE_CLIENT_KEYTAB), | ||
| configuration); | ||
|
|
||
| kerberosClient.login(tempDir + HIVE_METASTORE_CLIENT_KEYTAB); |
There was a problem hiding this comment.
I'm afraid the normal user couldn't do kerberosClient.login in spark-sql or spark-shell, may be you could try add spark.kerberos.principal and spark.kerberos.keytab to spark config.
There was a problem hiding this comment.
OK, let me optimized it.
FANNG1
reviewed
Nov 1, 2024
| // Login kerberos and use the users to execute the spark job. | ||
| try { | ||
| Configuration configuration = new Configuration(); | ||
| configuration.set("hadoop.security.authentication", "kerberos"); |
There was a problem hiding this comment.
please set all configurations in spark config.
There was a problem hiding this comment.
This line is only for Kerberos login, it's not for spark.
|
Could you add the document? |
The document about how to use Spark to access Iceberg rest with Kerberized Hive backend? |
|
@yuqi1129 please move forward this PR, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make IcebergRestKerberosHiveCatalogIT can run in deploy mode.
Why are the changes needed?
We need to make it work in both embedded and deploy mode.
Fix: #5410
Does this PR introduce any user-facing change?
N/A.
How was this patch tested?
Existing IT.