This repository has been archived by the owner on Apr 4, 2021. It is now read-only.
FALCON-1930 : testProcessInstanceRerunFailedWorkflowAction failed with NULLPOINTEREXCEPTION #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h NULLPOINTEREXCEPTION
muraliramasami
changed the title
| @@ -714,7 +714,9 @@ public static String getActionStatus(OozieClient oozieClient, String workflowId, | |||
| List<WorkflowAction> wfAction = oozieClient.getJobInfo(workflowId).getActions(); | |||
| for (WorkflowAction wf : wfAction) { | |||
| if (wf.getName().contains(actionName)) { | |||
| return wf.getExternalStatus(); | |||
| if (wf.getExternalStatus() != null) { | |||
There was a problem hiding this comment.
please use 'and' operator in if condition and combine both the if statements for better readability.
There was a problem hiding this comment.
@PraveenAdlakha Thanks for the review. I have modified the code.
| @@ -713,7 +713,7 @@ public static String getActionStatus(OozieClient oozieClient, String workflowId, | |||
| throws OozieClientException { | |||
| List<WorkflowAction> wfAction = oozieClient.getJobInfo(workflowId).getActions(); | |||
| for (WorkflowAction wf : wfAction) { | |||
| if (wf.getName().contains(actionName)) { | |||
| if ((wf.getName().contains(actionName)) && (wf.getExternalStatus() != null)) { | |||
There was a problem hiding this comment.
Do we know why we got null in the first place ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testProcessInstanceRerunFailedWorkflowAction tests execute the oozie workflow and when executes, the parent workflow returns null for getExternalStatus during the initial function call and the test failing with Null Pointer Exception. Added the condition to handle that case.