Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polaris registry support #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Zod-Li
Copy link

@Zod-Li Zod-Li commented Dec 28, 2021

What this PR does

support polaris registry for service discovery

Which issue(s) this PR fixes:

Issues

@Zod-Li Zod-Li mentioned this pull request Jan 6, 2022
public interface Constants {

/**
* 是否开启 Provider 侧主动服务注册
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please translate to English for all

@@ -0,0 +1,95 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add ASF license header for all files

Comment on lines +18 to +20
/**
* @author karimli
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove author annotation

@songxiaosheng
Copy link
Member

please fix conficts, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants