Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-SPI-Extensions] Add Intergration Test #556

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[Dubbo-SPI-Extensions] Add Intergration Test #556

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e5b2e3
ci: Intergration Test
shaokeyibb Nov 5, 2024
5209657
Merge branch 'master' into master
songxiaosheng Nov 8, 2024
c445157
Merge remote-tracking branch 'upstream/master'
shaokeyibb Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 66 additions & 0 deletions .github/workflows/build-and-test-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,3 +338,69 @@ jobs:
# with:
# name: "error-inspection-result"
# path: ${{ github.workspace }}/dubbo-test-tools/dubbo-error-code-inspector/error-inspection-result.txt

intergration-test:
needs: [check-license, build-source, unit-test-prepare]
name: "Intergration Test with JDK ${{ matrix.jdk }}"
runs-on: ubuntu-latest
strategy:
matrix:
jdk: [8, 11]
fail-fast: false
env:
DISABLE_FILE_SYSTEM_TEST: true
CURRENT_ROLE: ${{ matrix.case-role }}
steps:
- name: Checkout Self
uses: actions/checkout@v4
- name: Checkout dubbo-spi-samples
uses: actions/checkout@v4
with:
repository: apache/dubbo-spi-samples
path: dubbo-spi-samples
- name: "Set up JDK ${{ matrix.jdk }}"
uses: actions/setup-java@v4
with:
distribution: "zulu"
java-version: ${{ matrix.jdk }}
- uses: actions/cache@v4
name: "Cache local Maven repository"
with:
path: ~/.m2/repository
key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}-${{ github.run_id }}
restore-keys: |
${{ runner.os }}-maven-
${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
- uses: actions/cache@v4
name: "Cache zookeeper binary archive"
id: "cache-zookeeper"
with:
path: ${{ github.workspace }}/.tmp/zookeeper
key: zookeeper-${{ runner.os }}-${{ env.ZOOKEEPER_VERSION }}
restore-keys: |
zookeeper-${{ runner.os }}-
- uses: actions/cache@v4
name: "Cache secret key"
id: "cache-secret-cert"
with:
path: ${{ github.workspace }}/.tmp/rsa
key: secret-rsa-${{ runner.os }}-${{ github.run_id }}
- name: Calc Dubbo Version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach does not integrate the two test environments very well, you can check the log of the action, all tests are ignored.

Copy link
Author

@shaokeyibb shaokeyibb Nov 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a known issue since most of spi-samples require their dubbo version to 3.2* which is configured in case-versions.conf instad of our 3.3.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a known issue since most of spi-samples require their dubbo version to 3.2* instad of our 3.3 which is configured in case-versions.conf.

So the logic of the spi-samples repository is broken, and I think it's enough to limit the spi-extensions version. The current configuration of the samples repository is just for use, not anything special.

id: vars
run: |
REVISION=`awk '/<revision>[^<]+<\/revision>/{gsub(/<revision>|<\/revision>/,"",$1);print $1;exit;}' pom.xml`
echo "::set-output name=version::$REVISION"
echo "dubbo version: $REVISION"
- name: Init Test Environment
run: |
DUBBO_VERSION="${{ steps.vars.outputs.version }}"
CANDIDATE_VERSIONS="dubbo.version:$DUBBO_VERSION;compiler.version:$DUBBO_VERSION;dubbo.compiler.version:$DUBBO_VERSION;java.version:${{matrix.jdk}};$CANDIDATE_VERSIONS"
echo "CANDIDATE_VERSIONS=$CANDIDATE_VERSIONS" >> $GITHUB_ENV
- name: Build Test Image
run: |
cd dubbo-spi-samples
./test/build-test-image.sh
- name: Run Tests
run: |
cd dubbo-spi-samples
./test/run-tests.sh
Loading