Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcd support mapping #438

Open
wants to merge 2 commits into
base: 3.3
Choose a base branch
from
Open

Conversation

qyi71
Copy link
Contributor

@qyi71 qyi71 commented Jul 3, 2024

What is the purpose of the change

etcd support mapping

Brief changelog

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before
    you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
    just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit
    in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
    exist. If the new feature or significant change is committed, please remember to add sample
    in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure
    unit-test and integration-test pass.
  • If this contribution is large, please follow
    the Software Donation Guide.

@qyi71
Copy link
Contributor Author

qyi71 commented Jul 3, 2024

@songxiaosheng PTAL
ref:apache/dubbo#14337

@wcy666103
Copy link
Contributor

The review can be referenced here #380

@qyi71
Copy link
Contributor Author

qyi71 commented Jul 8, 2024

The review can be referenced here #380

I have some doubts, what do I need to do ?,i need consistent with the 'registerServiceAppMapping' method? or close this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants