Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate the circuitbreaker and ratelimit filters, to make it more decompose to developers #187

Merged
merged 2 commits into from
Dec 30, 2022

Conversation

andrewshan
Copy link
Contributor

What is the purpose of the change

separate the circuitbreaker and ratelimit filters, to make it more decompose to developers

Brief changelog

#91

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before
    you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
    just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit
    in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
    exist. If the new feature or significant change is committed, please remember to add sample
    in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure
    unit-test and integration-test pass.
  • If this contribution is large, please follow
    the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2022

Codecov Report

Merging #187 (d03390a) into master (e983761) will decrease coverage by 1.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #187      +/-   ##
============================================
- Coverage     35.71%   34.61%   -1.10%     
+ Complexity      531      519      -12     
============================================
  Files           155      154       -1     
  Lines          5539     5468      -71     
  Branches        690      685       -5     
============================================
- Hits           1978     1893      -85     
- Misses         3330     3351      +21     
+ Partials        231      224       -7     
Impacted Files Coverage Δ
...g/p2p/exchange/support/MulticastExchangeGroup.java 77.50% <0.00%> (-5.00%) ⬇️
...ache/dubbo/remoting/transport/mina/MinaClient.java 56.92% <0.00%> (-1.54%) ⬇️
...org/apache/dubbo/registry/redis/RedisRegistry.java 53.18% <0.00%> (-1.50%) ⬇️
.../dubbo/remoting/etcd/jetcd/JEtcdClientWrapper.java 0.00% <0.00%> (ø)
...istry/polaris/PolarisRegistryServiceDiscovery.java
...gistry/polaris/PolarisServiceDiscoveryFactory.java
...he/dubbo/registry/polaris/filter/ReportFilter.java 2.70% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit 420d6d6 into apache:master Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants