Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update javadoc for Authorizer interface and some public method in Access class - Policy must only be used for read table scope. #17636

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Update javadoc for Authorizer interface and some public method in Access class - Policy must only be used for read table scope. #17636

merged 1 commit into from
Jan 16, 2025

Conversation

cecemei
Copy link
Contributor

@cecemei cecemei commented Jan 16, 2025 •
edited
Loading

Description

Update javadoc for Access and Authorizer class, the key thing is to emphasis Policy must only be used for read table resource action.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@cecemei cecemei marked this pull request as ready for review January 16, 2025 16:25
@cecemei cecemei changed the title javadoc for authorizer Update javadoc for Authorizer interface and some public method in Access class - Policy must only be used for read table scope. Jan 16, 2025
@clintropolis clintropolis merged commit 05431fe into apache:master Jan 16, 2025
79 checks passed
@cecemei cecemei deleted the security-javadoc branch January 16, 2025 20:41
@cryptoe cryptoe added this to the 32.0.0 milestone Jan 17, 2025
cecemei added a commit to cecemei/druid that referenced this pull request Jan 17, 2025
@cecemei
javadoc for authorizer (apache#17636)
bf82efa
@cecemei cecemei mentioned this pull request Jan 17, 2025
Merged
cryptoe pushed a commit that referenced this pull request Jan 18, 2025
@cecemei
javadoc for authorizer (#17636) (#17642)
891e9ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianm gianm gianm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
32.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cecemei @gianm @clintropolis @cryptoe