Code Coverage additions for Extensions #17596
Conversation
github-actions
bot
added
Area - Batch Ingestion
Area - Metrics/Event Emitting
Area - Dependencies
Area - MSQ
| public class SSLContextProviderTest | ||
| { | ||
| @Mock | ||
| private SSLClientConfig mockConfig; |
There was a problem hiding this comment.
Why not create a concrete object instead of using a mock?
There was a problem hiding this comment.
Wanted to keep this in sync with SSLClientConfigTest, and then verify the getters are getting called. On another note, I think these tests are testing SSLClientConfig getters that are already tested in its own test class; so we can remove them.
| String expectedKeyManagerFactoryAlgorithm = "SunX509"; | ||
| Boolean expectedValidateHostnames = true; | ||
|
|
||
| // Use reflection to set the private fields |
There was a problem hiding this comment.
Please don't use reflection for this.
Either
- add a constructor
- OR, override the getters to return the expected values
- OR, deserialize the object from a json string
There was a problem hiding this comment.
Picked up the second option here to override the getters to return the expected values. Pushing changes in the next commit.
| } | ||
|
|
||
| @Test | ||
| public void testToString() |
There was a problem hiding this comment.
Do we really need to test the toString method? AFAICT, the toString of this class is used only for debug logging.
There was a problem hiding this comment.
Sounds good, removing in the next commit.
| } | ||
|
|
||
| @Test | ||
| public void testToString() |
There was a problem hiding this comment.
Sounds good, removing in the next commit.
ashwintumma23
force-pushed
the
codeCoverageExtensions
branch
from
af7daca to
84435fb
Compare
Description
extensions-coreandextensions-contribdirectoriesRelease note
Key changed/added classes in this PR
extensions-contrib/prometheus-emitter/src/test/java/org/apache/druid/emitter/prometheus/PrometheusEmitterConfigTest.javaextensions-contrib/prometheus-emitter/src/test/java/org/apache/druid/emitter/prometheus/PrometheusEmitterTest.javaextensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/indexing/MSQTaskListTest.javaextensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/indexing/MSQTuningConfigTest.javaextensions-core/simple-client-sslcontext/pom.xmlextensions-core/simple-client-sslcontext/src/test/java/org/apache/druid/https/SSLClientConfigTest.javaextensions-core/simple-client-sslcontext/src/test/java/org/apache/druid/https/SSLContextProviderTest.javaThis PR has: