Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] Improve Httpclient Connection #344

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

JNSimba
Copy link
Member

@JNSimba JNSimba commented Mar 18, 2024

Proposed changes

Issue Number: close #xxx

Problem Summary:

Connector uses HttpClient to send requests
When the FIN packet sent by the server is lost, subsequent HttpClient requests will reuse the last link, causing the request to report a Connection Reset error.
So here are two optimizations:

  1. For stream mode, add evictIdleConnections setting, which will regularly clean up expired connection.
  2. For batch mode, do not reuse the httpclient connection

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@JNSimba JNSimba merged commit e5bba52 into apache:master Mar 19, 2024
6 checks passed
@JNSimba JNSimba mentioned this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants