Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] Add DorisAbstractWriter, Unify DorisSink and DorisBatchSink #309

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

JNSimba
Copy link
Member

@JNSimba JNSimba commented Jan 26, 2024

Proposed changes

Currently, this PR implements batch writing of streamload, #168

However, at the datastream usage level, different sinks pose relatively large barriers to use for users, so we will unify them here.

Abstract DorisAbstractWriter and use parameters sink.write-mode to distinguish different writes

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@JNSimba JNSimba merged commit 9d7626f into apache:master Jan 29, 2024
8 checks passed
@JNSimba JNSimba mentioned this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants