Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]add arrow type for streamload #265

Merged
merged 7 commits into from
Dec 27, 2023

Conversation

wuwenchi
Copy link
Contributor

Proposed changes

add arrow type for streamload

Problem Summary:

Describe the overview of changes.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@JNSimba
Copy link
Member

JNSimba commented Dec 11, 2023

The writeRecord method of DorisStreamLoad or DorisBatchStreamload will splice lineDelimiter characters (\n). Will it have any impact when arrow format writing is enabled?

@JNSimba
Copy link
Member

JNSimba commented Dec 11, 2023

Only RowDataSerializer has been modified. Is it because other Serializers cannot obtain the written data type?

@wuwenchi
Copy link
Contributor Author

wuwenchi commented Dec 18, 2023

The writeRecord method of DorisStreamLoad or DorisBatchStreamload will splice lineDelimiter characters (\n). Will it have any impact when arrow format writing is enabled?

Will not be affected because lineDelimiter will be set to null when using arrow.

@wuwenchi
Copy link
Contributor Author

Only RowDataSerializer has been modified. Is it because other Serializers cannot obtain the written data type?

Yes

Copy link
Member

@JNSimba JNSimba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JNSimba JNSimba merged commit bad24da into apache:master Dec 27, 2023
8 checks passed
@JNSimba JNSimba mentioned this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants