fix: make get_valid_types handle TypeSignature::Numeric correctly #14060
+69
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niebayes
changed the title
niebayes
commented
Jan 9, 2025
Comment on lines
+554
to
+557
| } else if !logical_data_type.is_numeric() { | ||
| return plan_err!( | ||
| "The signature expected NativeType::Numeric but received {logical_data_type}" | ||
| ); |
There was a problem hiding this comment.
I'm not entirely clear on the rationale for falling back to Float64 when the argument is of type Null.
However, I choose to keep this logic and make it a short-circuit before the numeric check.
There was a problem hiding this comment.
f64 is chosen since it is the most compatible type of numeric
niebayes
commented
Jan 9, 2025
niebayes
commented
Jan 9, 2025
github-actions
bot
added
sqllogictest
|
I need to bump Rust to 1.84 to pass CI |
niebayes
force-pushed
the
fix/get_valid_types
branch
from
1d39025 to
3cf710c
Compare
github-actions
bot
removed
physical-expr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #14059.
Rationale for this change
What changes are included in this PR?
Make
get_valid_typeshandle TypeSignature::Numeric(n) correctly, for various n.Are these changes tested?
Yes, added a unit test.
Are there any user-facing changes?
No.