docs(ci): use up-to-date protoc with docs.rs #14048
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13853.
Rationale for this change
This uses the same basic solution as in
substrait-rs
:https://github.com/substrait-io/substrait-rs/blob/bbcc9f6d0b084a13706f39a43bbba9d37bf2a959/Cargo.toml#L62-L63
substrait-rs
has an optionalprotoc
feature0 The
protoc
feature adds a dependency onprotobuf-src
, which ensures a fixed version of the protobuf compiler by compiling/vendoring itbuild.rs
file, the vendored protoc is used when theprotoc
feature is enableddocs.rs
What changes are included in this PR?
Given that
datafusion-substrait
only uses theprotoc
compiler with thesubstrait-rs
crate and already has aprotoc
feature, we should be able to solve this problem by enabling theprotoc
feature fordocs.rs
, as done here.Are these changes tested?
This is difficult to test, as it depends on the
docs.rs
environment, which is hard to replicate.I have verified locally that adding the same version of
protoc
to my path as indocs.rs
leads to the problem, and is solved with enabling all features:I have attempted to replicate this in a
docs.rs
environment following the instructions here and here, but running it on any local crate gives an error likeinvalid type: null, expected a string at line 1 column 2617950
and fails, so I haven't been able to do so.Are there any user-facing changes?
No, other than that
docs.rs
should work again.